Skip to content

remove static name for nodepools and upgrade pulumi gcp plugin #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicu-da merged 5 commits into from
Jan 21, 2026
Merged

remove static name for nodepools and upgrade pulumi gcp plugin #3616

nicu-da merged 5 commits into from
Jan 21, 2026

Conversation

@nicu-da
Copy link
Contributor

@nicu-da nicu-da commented Jan 20, 2026

re-apply #3614 + some version update and removal of namePrefix that is borked, by default the resource name is the namePrefix

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@nicu-da
bump pulumi gcp resources
8546515 
also clean-up pulumi packages

[static]

Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
@nicu-da
why?
48caf6c 
[static]

Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
@nicu-da
Reapply "Add support to upgrade node pools in place (#3610)" (#3614)
90f1515 
This reverts commit d8c5197.

[static]

Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
@nicu-da
remove broken name prefix
54c8c53 
[static]

Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
@nicu-da
Copy link
Contributor Author

nicu-da commented Jan 20, 2026

tested on a scratch

@nicu-da nicu-da changed the title Nicuda/techdebt/bump pulumi gcp remove static name for nodepools and upgrade pulumi gcp plugin Jan 20, 2026
@nicu-da
.
173bed6 
[static]

Signed-off-by: Nicu Reut <nicu.reut@digitalasset.com>
martinflorian-da
martinflorian-da approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@martinflorian-da martinflorian-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just please plan to be around for the few hours after you click merge ✌️

@nicu-da nicu-da merged commit 548cc8f into main Jan 21, 2026
44 checks passed
@nicu-da nicu-da deleted the nicuda/techdebt/bump_pulumi_gcp branch January 21, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinflorian-da martinflorian-da martinflorian-da approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicu-da @martinflorian-da